Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow global settings more accurately whether to show snippet completions #2017

Merged
merged 4 commits into from
Aug 13, 2022

Conversation

jwortmann
Copy link
Member

This is part 2 of e14bf5d.

Now both of the builtin ST settings are respected. For example, I personally use

{
    "auto_complete_include_snippets": true,  // (default value)
    "auto_complete_include_snippets_when_typing": false,
}

plugin/documents.py Outdated Show resolved Hide resolved
@rchl
Copy link
Member

rchl commented Aug 12, 2022

auto_complete_include_snippets_when_typing

nice, didn't know that ST had that

@rchl
Copy link
Member

rchl commented Aug 12, 2022

auto_complete_include_snippets_when_typing

nice, didn't know that ST had that

Though I misunderstood its purpose at first. I thought that it's about excluding or not ST snippets while it's about snippet type completions from LSP. So that's maybe not so useful to me as LSP-typescript, for example, will sometimes return snippet-type completions that are specific to the context rather than just generic snippets so in that case I'd still want those when typing...

@rwols rwols merged commit b9b4aeb into sublimelsp:main Aug 13, 2022
@jwortmann jwortmann deleted the snippet-settings branch August 13, 2022 11:43
rchl added a commit that referenced this pull request Aug 25, 2022
* main:
  Follow global settings more accurately whether to show snippet completions (#2017)
  Add docs for ruby steep language server
  Update F# guidance
  Cut 1.17.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants